fix: make ManagementClusterClassifierReconciler shard-aware - #514
Merged
gianlucam76 merged 1 commit intoSep 16, 2026
Merged
Conversation
`ManagementClusterClassifierReconciler` never checked `ShardKey`, unlike `ClassifierReconciler`. In `fv-sharding` (two classifier-manager deployments, default + shard1), both instances reconciled the same `ManagementClusterClassifier` and raced to update labels on the same Cluster object. That caused the "multi-GVK requirement" FV test to time out waiting for labels to be removed after CR deletion. This PR fixes that. When `ShardKey` is set, no-op immediately, same as `ClassifierReconciler` already does. This resource is evaluated entirely against the management cluster itself, so sharded deployments have no role to play for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ManagementClusterClassifierReconcilernever checkedShardKey, unlikeClassifierReconciler.In
fv-sharding(two classifier-manager deployments, default + shard1), both instances reconciled the sameManagementClusterClassifierand raced to update labels on the same Cluster object. That caused the "multi-GVK requirement" FV test to time out waiting for labels to be removed after CR deletion.This PR fixes that. When
ShardKeyis set, no-op immediately, same asClassifierReconcileralready does. This resource is evaluated entirely against the management cluster itself, so sharded deployments have no role to play for it.