Skip to content

Switch to projectdiscovery rod fork - #2734

Open
Mzack9999 wants to merge 5 commits into
devfrom
rod-module
Open

Mzack9999 wants to merge 5 commits into
devfrom
rod-module

Conversation

@Mzack9999

@Mzack9999 Mzack9999 commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Moves the screenshot and browser code to the ProjectDiscovery rod fork, github.com/projectdiscovery/rod, pinned at cf8f6e3. Import paths change in 2 files. go is bumped to 1.27.4 because the fork requires it.

Summary by CodeRabbit

  • Chores
    • Updated the app’s underlying browser automation and runtime requirements. These changes do not alter visible features or workflows, so the app continues to work as before. No user action is required.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • Resume reviews
  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The module’s Go version requirement changes to 1.27.4. The Rod dependency and the headless runner’s Rod imports change to projectdiscovery/rod. The headless test updates its launcher import to the same module.

Changes

Rod dependency migration

Layer / File(s) Summary
Update Rod dependency and imports
go.mod, runner/headless.go, runner/headless_test.go
The module replaces go-rod/rod with projectdiscovery/rod and removes four indirect dependencies. The headless runner and its test use the new import paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: dogancanbakir

Merge Risk: Minimal · up to db677

This updates the headless browser dependency to the ProjectDiscovery Rod fork and requires Go 1.27.4. No concrete merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Switch to projectdiscovery rod fork" matches the main change. The PR replaces the go-rod/rod dependency with the projectdiscovery/rod fork in go.mod, runner/headless.go, and runner/headless…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Switch to projectdiscovery rod fork" matches the main change. The PR replaces the go-rod/rod dependency with the projectdiscovery/rod fork in go.mod, runner/headless.go, and runner/headless_test.go, and raises the Go directive to 1.27.4 because the fork requires it. The title is short, specific, and free of noise. It does not mention the Go version bump, but that is secondary to the dependency switch.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the module line,
Then follows Rod through paths aligned.
New imports hop from file to file,
Four old leaves fall into a pile,
The test joins in with ears held high.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8971e4c9-8b28-47fb-8e58-05938d2a0819
Commits

Reviewing files that changed from the base of the PR and between 7dc2da6 and db67786.

Files ignored due to path filters: 1

  • go.sum is excluded by !**/*.sum
Files selected for processing: 1

  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant