Repository navigation
fix: do not over-indent a comment-only array in a return statement - #2556
Open
benjaminkincses wants to merge 3 commits into
Open
benjaminkincses wants to merge 3 commits into
benjaminkincses wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1864
Returning an array that holds only a comment printed the comment one level too deep and indented the closing bracket:
The return printer wrapped the expression in indent() whenever the expression had any comments. Dangling comments are printed by the expression itself at its own indent, so the extra wrap shifted them and the closing line one level too far. The wrap now only applies when the expression has leading or trailing comments.
Added tests/array/empty-comment.php with the cases from the issue, including the same return inside a function. Full jest suite passes: 104 suites, 602 tests, no other snapshots changed.