Conversation
`merge_dicts()` had an equality check (`left_v == right_v → continue`) before the str/dict/list branches. When a streamed text delta happened to equal the full accumulation so far (e.g. "\n" + "\n"), the second delta was silently dropped — both at the string-leaf level and at the container level (an equal dict skipped recursion entirely). Move the str/dict/list branches before the equality check, matching langchain's original ordering. Strings always concatenate, containers always recurse, and the equality check now only applies to remaining scalar types (int, float, bool). Closes #435
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #435
Summary
merge_dicts()had an equality check (left_v == right_v → continue) before the str/dict/list branches. When a streamed text delta happened to equal the full accumulation so far (e.g."\n"+"\n"), the second delta was silently dropped — both at the string-leaf level and at the container level (an equal dict skipped recursion entirely).The fix reorders the branches to match langchain's original ordering (from which this code was adapted). Strings always concatenate, containers always recurse, and the equality check now only applies to remaining scalar types (int, float, bool).
All providers that stream via
merge_dicts()are affected:ChatOllama(),ChatGroq(),ChatDeepSeek(),ChatOpenRouter(),ChatDatabricks(),ChatGoogle(), andChatOpenAICompletions().Verification