Skip to content

feat: Add entry point types - #8009

Merged
camdecoster merged 7 commits into
mainfrom
cam/8004/add-entry-point-types
Sep 4, 2026
Merged

feat: Add entry point types#8009
camdecoster merged 7 commits into
mainfrom
cam/8004/add-entry-point-types

Conversation

@camdecoster

@camdecoster camdecoster commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

Add TypeScript types for entry points in lib/.

Closes #8004.

Changes

  • Add entry point types and generator scripts
  • Update CI
  • Update TS docs

Testing

Check that CI is passing.

Notes

  • There are a number of alternate entry points for plotly.js in lib/
  • This PR adds types for these in addition to the main entry point lib/index.js
  • I opted to locate these in the generated types folder rather than along with the entry point files to keep things tidy
  • Type resoultion happens via the typesVersions object in package.json
  • The types are generated rather than hand written. This might not be necessary given that the entry points don't change very often, but it makes it automated so we don't have to think about it.

KoolADE85
KoolADE85 previously approved these changes Sep 3, 2026

@KoolADE85 KoolADE85 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update, it's working cleanly on my end. 💃

@camdecoster
camdecoster marked this pull request as ready for review September 4, 2026 14:56
@camdecoster
camdecoster merged commit a1f2c54 into main Sep 4, 2026
78 of 80 checks passed
@camdecoster
camdecoster deleted the cam/8004/add-entry-point-types branch September 4, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: components don't have type definitions

2 participants