fix(web): label keybinding condition removal actions - #8664
fix(web): label keybinding condition removal actions#8664RakshithBhat03 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused accessibility and usability fix that clarifies the scope of existing keybinding removal buttons through labels and tooltips. Removal behavior, persistence, defaults, and other runtime workflows remain unchanged, with the new labeling logic covered by tests. You can add or adjust custom eligibility rules. Learn more. |
The minus buttons in the keybinding
Wheneditor did not explain whether they removed one condition, a nested group, or the entire expression. Their accessible names were inconsistent with the scope of the action too.Each action now uses the styled tooltip component and a matching accessible label:
Remove condition,Remove group and its conditions, orClear all conditions. The existing neutral hover treatment stays unchanged.Tests: 10 focused tests, web typecheck, targeted lint.
Built by GPT-5.6 Sol in T3 Code through the Codex harness.