Skip to content

fix(web): label keybinding condition removal actions - #8664

Open
RakshithBhat03 wants to merge 1 commit into
pingdotgg:mainfrom
RakshithBhat03:fix/keybinding-remove-tooltips
Open

fix(web): label keybinding condition removal actions#8664
RakshithBhat03 wants to merge 1 commit into
pingdotgg:mainfrom
RakshithBhat03:fix/keybinding-remove-tooltips

Conversation

@RakshithBhat03

@RakshithBhat03 RakshithBhat03 commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

The minus buttons in the keybinding When editor did not explain whether they removed one condition, a nested group, or the entire expression. Their accessible names were inconsistent with the scope of the action too.

Each action now uses the styled tooltip component and a matching accessible label: Remove condition, Remove group and its conditions, or Clear all conditions. The existing neutral hover treatment stays unchanged.

Tests: 10 focused tests, web typecheck, targeted lint.

Before After
Keybinding When builder before contextual tooltips Remove condition tooltip

Clear all conditions tooltip

Built by GPT-5.6 Sol in T3 Code through the Codex harness.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fabab51c-02b9-499a-a3db-0e1a3b512b59

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 29, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 84bc38c

Macroscope's review found this PR approvable — This is a focused accessibility and usability fix that clarifies the scope of existing keybinding removal buttons through labels and tooltips. Removal behavior, persistence, defaults, and other runtime workflows remain unchanged, with the new labeling logic covered by tests.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant