fix(web): keep environment pill inside narrow sidebar - #8663
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
One regression found: overflow-hidden on SidebarHeader clips the stage backdrop art that intentionally bleeds below the header.
Posted via Macroscope — UI Consistency
There was a problem hiding this comment.
One finding on the new header wrapper: its overflow-hidden clips the brand link's focus ring. Details inline.
Non-blocking observation: because SidebarBrand is hidden below md, ml-auto on the badge also right-aligns the pill in the mobile sheet header (--sidebar-width: calc(100vw - …)), where it previously sat next to the trigger and could not overflow. If that relocation isn't intended, md:ml-auto keeps the mobile placement while still right-aligning on desktop.
Posted via Macroscope — UI Consistency
There was a problem hiding this comment.
One finding: the new wrapper's overflow-hidden clips the brand link's focus-visible ring. Details inline.
Posted via Macroscope — UI Consistency
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a focused production sidebar layout fix, but the new flex wrapper may clip the brand link’s visible keyboard focus ring because of You can add or adjust custom eligibility rules. Learn more. |
What Changed
Why
When Environment identification is set to Version pill, resizing the sidebar to its minimum width can push the Dev or Nightly pill into the main page header.
The Nightly label makes the problem especially visible because it is wider. The header should preserve the T3 wordmark and environment pill at every supported sidebar width.
Fixes #8660
UI Changes
Before
header-before.mov
After
Screen.Recording.2026-08-29.at.9.22.50.PM.mov
Checklist
Built with GPT-5.6 Sol in T3 Code through the Codex harness.
Note
Low Risk
CSS-only sidebar header layout and responsive label visibility; no auth, data, or API changes.
Overview
Fixes environment identification pills (e.g. Dev/Nightly) overflowing into the main header when the sidebar is at minimum width.
Sidebar header layout wraps the T3 brand link and environment pill in a single flex row with
min-w-0 flex-1, moves the desktop titlebar left inset to that wrapper, and keeps the pillshrink-0with slightly tighter padding andmd:ml-autoso both stay within the sidebar.Brand label behavior drops the per-link titlebar margin and hides the “Code” text by default on non-backdrop headers, showing it only when the header container is at least 15rem wide (
@[15rem]/sidebar-header), while the wordmark and pill remain visible at all supported widths.Reviewed by Cursor Bugbot for commit 24b2d39. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix environment pill overflow in narrow sidebar header
SidebarBrandand the environment pillBadgein a new flex container withmin-w-0so the pill stays inside the sidebar on narrow widths instead of overflowingmd:ml-auto) and trims its horizontal padding (px-1.5→px-1)@[15rem]/sidebar-header:inline), except on backdrop where it stays visiblez-10,shrink-0, and left-margin spacing off the individual children onto the wrapper divMacroscope summarized 24b2d39.