chore(deps): bump Electron to 43.4.1 - #8626
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR makes a major Electron 41-to-43 runtime upgrade and changes the default preview-session storage cleanup policy by removing WebSQL. Both affect shipped desktop behavior, so the change warrants human review. You can add or adjust custom eligibility rules. Learn more. |
|
Independently double-checked this dependency bump. |
Electron 41 is no longer supported. This moves the desktop app to the supported Electron 43 line without taking the additional Electron 44 breaking changes.
The upgrade updates Electron and its lockfile graph, then removes the obsolete WebSQL storage type that Electron 43 no longer accepts. electron-updater and all other direct dependencies remain unchanged.
Checks:
Made with GPT-5.6-sol through the Codex harness in T3 Code.
Note
Medium Risk
A two-major Electron bump can surface deprecated APIs or runtime behavior outside the areas covered by tests; the WebSQL removal is a targeted compatibility fix for storage clearing.
Overview
Moves the desktop app from unsupported Electron 41.5.0 to 43.4.1 (supported line, without jumping to Electron 44). The lockfile updates Electron’s install graph (e.g.
@electron/get@5.1.0, internalextract-zip).Preview session cleanup drops
websqlfromclearStorageDatainBrowserSession.clearCookies, since Electron 43 no longer accepts that storage type; the matching test expectation is updated. Other direct deps (includingelectron-updater) are unchanged in this diff.Reviewed by Cursor Bugbot for commit 9e77068. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Bump Electron from 41.5.0 to 43.4.1 and remove
websqlfromclearStorageData'websql'from the storages array inBrowserSession.clearCookiesin BrowserSession.ts and the matching assertion in BrowserSession.test.ts.Macroscope summarized 9e77068.