Skip to content

chore(deps): bump Electron to 43.4.1 - #8626

Open
StiensWout wants to merge 2 commits into
pingdotgg:mainfrom
StiensWout:t3code/upgrade-electron-43
Open

chore(deps): bump Electron to 43.4.1#8626
StiensWout wants to merge 2 commits into
pingdotgg:mainfrom
StiensWout:t3code/upgrade-electron-43

Conversation

@StiensWout

@StiensWout StiensWout commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Electron 41 is no longer supported. This moves the desktop app to the supported Electron 43 line without taking the additional Electron 44 breaking changes.

The upgrade updates Electron and its lockfile graph, then removes the obsolete WebSQL storage type that Electron 43 no longer accepts. electron-updater and all other direct dependencies remain unchanged.

Checks:

  • 5 focused desktop and packaging test files, 83 tests
  • desktop typecheck
  • desktop and server production build
  • Electron launch smoke test

Made with GPT-5.6-sol through the Codex harness in T3 Code.


Note

Medium Risk
A two-major Electron bump can surface deprecated APIs or runtime behavior outside the areas covered by tests; the WebSQL removal is a targeted compatibility fix for storage clearing.

Overview
Moves the desktop app from unsupported Electron 41.5.0 to 43.4.1 (supported line, without jumping to Electron 44). The lockfile updates Electron’s install graph (e.g. @electron/get@5.1.0, internal extract-zip).

Preview session cleanup drops websql from clearStorageData in BrowserSession.clearCookies, since Electron 43 no longer accepts that storage type; the matching test expectation is updated. Other direct deps (including electron-updater) are unchanged in this diff.

Reviewed by Cursor Bugbot for commit 9e77068. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Bump Electron from 41.5.0 to 43.4.1 and remove websql from clearStorageData

  • Updates the Electron dependency in package.json from 41.5.0 to 43.4.1 and refreshes the lockfile.
  • Removes 'websql' from the storages array in BrowserSession.clearCookies in BrowserSession.ts and the matching assertion in BrowserSession.test.ts.
  • Risk: Electron 43 is a major version jump (41 → 43); other deprecated or removed Electron APIs not yet surfaced by tests may cause runtime or build regressions.

Macroscope summarized 9e77068.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 79d891e4-0d3a-49e3-a4df-d9c8393ae3aa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 29, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR makes a major Electron 41-to-43 runtime upgrade and changes the default preview-session storage cleanup policy by removing WebSQL. Both affect shipped desktop behavior, so the change warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge juliusmarminge added the preview:mac Build an Apple Silicon DMG for this PR on every push. label Aug 29, 2026
@MatthewFeroz

Copy link
Copy Markdown

Independently double-checked this dependency bump.
• Audited T3's Electron API usage against the Electron 42/43 breaking changes
• Confirmed the websql removal is required and no other affected APIs appear to be used
• Verified the lockfile change is limited to Electron's dependency graph
• Ran the full desktop suite: 625 tests passed
• Ran 678 focused GitHub, source-control, and PR integration tests
• Desktop typecheck, server build, desktop build, and Electron launch smoke test passed
• Confirmed electron-updater is unchanged and @clerk/electron supports
Electron 43
I found no blocking regressions. The remaining gap is packaged smoke testing on macOS and Windows; the macOS preview artifact was skipped in Cl. Code-wise, this looks safe to approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:mac Build an Apple Silicon DMG for this PR on every push. size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants