Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe binlog event filtering documentation now refers to the ChangesBinlog filter documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: 🔵 Low · up to Users can identify the intended field, but the instruction is ungrammatical. Correcting the wording is a small documentation fix before merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The task configuration file field is documented as filters (plural) throughout DM docs, e.g. task-configuration-file-full.md's #### `filters` heading, and the YAML example immediately following this sentence.
db8ae05 to
eb3a9d3
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: ebdd9e74-f3e6-4439-a451-b910884bc95f
📒 Files selected for processing (1)
filter-binlog-event.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
Found by CodeRabbit review on PR pingcap#23838. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
What is changed, added or deleted? (Required)
"add a `filter` to the task configuration file of DM" uses the singular `filter`, but the field name is `filters` (plural) — as shown in the very next code block in this same file, and documented via the `#### `filters` {#filters}` heading in `dm/task-configuration-file-full.md`.
Source-code verification: `dm/config/task.go` defines the field as `Filters map[string]*bf.BinlogEventRule `yaml:"filters" toml:"filters" json:"filters"`` — confirming `filters` (plural) is the actual field name recognized by DM, in both the YAML task config and its TOML/JSON representations.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
filtersconfiguration key, matching the accompanying YAML example.