Skip to content

Fix DATATIME typo and precision/scale wording - #23724

Open
yahonda wants to merge 1 commit into
pingcap:masterfrom
yahonda:fix-datatime-typo-and-precision-scale
Open

yahonda wants to merge 1 commit into
pingcap:masterfrom
yahonda:fix-datatime-typo-and-precision-scale

Conversation

@yahonda

@yahonda yahonda commented Sep 3, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

  • sql-mode.md: fixes a typo, DATATIMEDATETIME, in the ALLOW_INVALID_DATES mode description.
  • tidb-troubleshooting-map.md: DECIMAL(a, b) uses a for precision and b for scale; the text called both "the target precisions".

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected a data type typo in the SQL mode reference.
    • Clarified the meanings of precision and scale parameters in a decimal conversion troubleshooting workaround.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 819a8313-2762-4dfb-83ec-9b6ffd05270a

📥 Commits

Reviewing files that changed from the base of the PR and between 0dc31ea and 0c3a2d8.

📒 Files selected for processing (2)
  • sql-mode.md
  • tidb-troubleshooting-map.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The change corrects two documentation inaccuracies: DATATIME is changed to DATETIME, and decimal casting parameters are described as precision and scale.

Changes

Documentation corrections

Layer / File(s) Summary
SQL terminology corrections
sql-mode.md, tidb-troubleshooting-map.md
The ALLOW_INVALID_DATES description uses DATETIME. The decimal casting workaround identifies a as precision and b as scale.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 8ef55

The changes improve documentation accuracy without affecting runtime behavior, so the PR is mergeable.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description identifies both documentation fixes, specifies the affected TiDB versions, provides a reference, and completes the applicable template sections. Optional fields are left blank appropri…
Title check ✅ Passed The title clearly summarizes both changes: the DATATIME typo correction and the precision/scale wording correction.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Sep 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2026
@yahonda

yahonda commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@yahonda

yahonda commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@yahonda

yahonda commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 37 minutes.

@yahonda

yahonda commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

sql-mode.md: DATATIME was a misspelling of DATETIME.
tidb-troubleshooting-map.md: DECIMAL(a, b) uses a for precision and
b for scale, not both for precision.

Found while reviewing CodeRabbit feedback on the Japanese translation
of these two files.
@yahonda
yahonda force-pushed the fix-datatime-typo-and-precision-scale branch from 0c3a2d8 to 8ef5510 Compare September 18, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant