Skip to content

Refactor entities and operators - #205

Merged
iMattPro merged 1 commit into
phpbb-extensions:dev/4.0from
iMattPro:dev/4.0-refactor-entities
Sep 24, 2026
Merged

iMattPro merged 1 commit into
phpbb-extensions:dev/4.0from
iMattPro:dev/4.0-refactor-entities

Conversation

@iMattPro

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (7bac3ba) to head (e65915a).

Additional details and impacted files
@@              Coverage Diff              @@
##             dev/4.0     #205      +/-   ##
=============================================
- Coverage      96.64%   96.20%   -0.45%     
- Complexity       257      265       +8     
=============================================
  Files             20       21       +1     
  Lines            864      895      +31     
=============================================
+ Hits             835      861      +26     
- Misses            29       34       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Keep hydration side-effect free so stored values are not transformed as new input. Use explicit factories and update only dirty fields.

BREAKING CHANGE: Page and rule entities no longer expose load(), insert(), or save(). Their non-shared service IDs were also removed. Use operator create, get, add, and save methods instead.

Refinements to refactoring
@iMattPro
iMattPro force-pushed the dev/4.0-refactor-entities branch from af9dfbb to e65915a Compare September 23, 2026 04:40
@iMattPro
iMattPro merged commit 2e0189a into phpbb-extensions:dev/4.0 Sep 24, 2026
29 checks passed
@iMattPro
iMattPro deleted the dev/4.0-refactor-entities branch September 24, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants