Table caption fix/update - #1994
Open
pwright64 wants to merge 1 commit into
Open
Conversation
Change to table caption (table titles) behavior in mobile to fix table captions squishing and splitting to 3 lines. Increased .doctable caption line-height to 2rem for better readability.
pwright64
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
August 21, 2026 16:00
Contributor
Author
|
I'm not sure why the static analysis failed, but stylesheet changes did fine on my local php.net. If examples are needed for the changes: https://www.php.net/manual/en/mysqli.summary.php & https://www.php.net/manual/en/about.prototypes.php |
Contributor
|
🚀 Preview for commit 0925948 is available at https://web-php-pr-1994.preview.thephp.foundation |
Member
|
Could you add a screenshot with before and after? The preview doesn't have all the documentation pages. I would also prefer it if you split up the white-space-only changes from actual code-changes (same PR is fine, but in two separate commits, please). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change to table caption (table titles) behavior in mobile to fix table captions squishing and splitting to 3 lines. Also, increased .doctable caption line-height to 2rem for better readability.