ext/pdo_pgsql: Fix PDO::CURSOR_SCROLL statements failing under lazy fetching - #23471
Closed
KentarouTakeda wants to merge 1 commit into
Closed
ext/pdo_pgsql: Fix PDO::CURSOR_SCROLL statements failing under lazy fetching#23471KentarouTakeda wants to merge 1 commit into
KentarouTakeda wants to merge 1 commit into
Conversation
KentarouTakeda
requested review from
SakiTakamachi and
devnexen
as code owners
August 26, 2026 09:40
devnexen
reviewed
Aug 26, 2026
| : H->default_fetching_laziness | ||
| ; | ||
|
|
||
| if (scrollable) { |
Member
There was a problem hiding this comment.
nit: S->is_unbuffered computation above and setting it if scrollable should go up after scrollable computation wdyt ?
Contributor
Author
There was a problem hiding this comment.
Applied. Thanks.
KentarouTakeda
force-pushed
the
fix-pdo-pgsql-cursor-lazy-fetch
branch
from
August 26, 2026 23:41
a070d76 to
bd15b50
Compare
KentarouTakeda
force-pushed
the
fix-pdo-pgsql-cursor-lazy-fetch
branch
from
August 26, 2026 23:42
bd15b50 to
b143c49
Compare
devnexen
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A statement prepared with
PDO::ATTR_CURSOR => PDO::CURSOR_SCROLLand lazy fetching (PDO::ATTR_PREFETCH => 0) fails atexecute()withSQLSTATE[HY000]: General error: 7and no message. Either option alone works.A cursor does not stream its result, but
S->is_unbufferedstays set, soexecute()callsPQgetResult()with nothing in flight. The fix clears the flag when the statement has a cursor.The test is David Carlier's, from #23210.