Return false from rewrite_name_to_position() on IM001 error path - #23465
Open
iliaal wants to merge 1 commit into
Open
Return false from rewrite_name_to_position() on IM001 error path#23465iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
Contributor
|
Does it make sense to add regression test for it? |
rewrite_name_to_position() returns bool, so the previous -1 was converted to true and the caller's failure check never triggered after raising the IM001 error for a repeated named parameter, leaving bindParam()/bindColumn() reporting success. Sibling audit: no other -1 return remains in this function; the other error paths already return 0.
iliaal
force-pushed
the
fix/pdo-rewrite-name-im001-84
branch
from
August 26, 2026 21:26
f451d5a to
ec5fbc2
Compare
Contributor
Author
|
No. The IM001 return is not reached from bindParam or bindValue: the loop returns on the first matching name, so paramno is never already set. bindColumn does not call rewrite_name_to_position. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewrite_name_to_position() is declared bool, so the -1 returned after raising the IM001 error for a repeated :named parameter was converted to true and the caller's failure check never saw the failure, leaving bindParam() and bindColumn() reporting success despite the error. Returning false makes the error propagate; no other -1 return remains in the function.