Fix GH-23453: bad free with a context engine ID longer than 32 bytes - #23456
Open
lazerg wants to merge 2 commits into
Open
Fix GH-23453: bad free with a context engine ID longer than 32 bytes#23456lazerg wants to merge 2 commits into
lazerg wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
netsnmp_session_set_contextEngineID()passes an emalloc()'d buffer tosnmp_hex_to_binary()withallow_reallocset. A context engine ID longer than the 32-byte buffer makes net-snmp callsnmp_realloc()on that pointer, which aborts the process.RFC 3411 caps the engine ID at 32 bytes anyway, so this drops
allow_realloc: an oversized value now hits the existing "Bad engine ID value" warning and returns false.Fixes GH-23453