Fix GH-23418: UAF when accessing mounted Phar subdirectories - #23442
Merged
Conversation
devnexen
approved these changes
Aug 25, 2026
pull Bot
pushed a commit
to dolfly/php-src
that referenced
this pull request
Aug 26, 2026
* origin/PHP-8.4: Fix phpGH-23418: UAF when accessing mounted Phar subdirectories (php#23442)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UAF is basically because we trick the
phar_mount_entryto fail and the code goes toSelf-evident buggy code I'd say... we freed test and use it in spprintf. And guess what, the whole function repeats this insane logic later again. So this is fixing two potential UAFs.
Here we passes a properly null-terminated copy of the shortened path to
phar_mount_entry()instead and keeptestalive until error formatting and manifest lookup have completed.