fix(bridge-rector): drop #[\Override] left dangling after detaching from TestCase - #353
Merged
Merged
Conversation
… from `TestCase` Once `extends TestCase` is removed, `#[\Override]` on `setUp()` and other `TestCase` hooks has no parent method and PHP rejects the class. Methods declared by an implemented interface keep it; an unresolvable interface keeps all of them. Assisted-By: Claude Opus 5.5
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
ExtendsTestCaseToTestoRectornow drops#[\Override]from methods that override nothing onceextends TestCaseis removed:setUp(),tearDown(),setUpBeforeClass()and otherTestCasehooks.#[\Override]attributes stay.Why?
After conversion the class has no parent, so PHP rejects
#[\Override]on the formerTestCasehooks.Checklist
Bridge/RectorandBridge/Rector/Unitsuites pass locally