Repository navigation
Add group_by and filter evictions to on_remove - #3281
Merged
Merged
Conversation
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
View::on_removeevent handler registration to tick rows that were removed form theViewdue togroup_bygroups becoming empty, as well asfilterconditions removing them. This change allows Perspective' client-server replicated deployment to be a closer duplication, though it still does not handle live column eviction due tosplit_bygroups becoming empty (this still requires an explicit schema on theTableat construction).on_remove's callback itself now has an second argument which marks the source of the removal -"filter","group"and"key"types. For Python, this PR also makes this signature andon_update's recent callback signature update optional (viainspect, so may not work with e.g.pyo3bindings directly) but you will still get the new events if you do not register this.In addition, updates on the
on_updatecallback for groupedViews now also emit thegroup_byrows, andTables derived from these will use thegroup_bycolumns asindexby default. Together,client.able(view)constructions should now be symmetric (modsplit_bynote above).Drivebys
max,median,q3,high minus lowreturn null, andlowreturns 0, when a group contains a null #3278