[FEATURE] enhance StatChart with text mode options and refactor display l… - #524
[FEATURE] enhance StatChart with text mode options and refactor display l…#524abelyakin wants to merge 5 commits into
Conversation
…ogic - Introduced a new property in the StatChart schema to control how values and names are displayed. - Updated the migration logic to map from panel options and handle various display scenarios. - Refactored the StatChartBase component to utilize for determining what to display (value, name, both, or none). - Adjusted tests and expected outputs to reflect changes in text mode handling. - Enhanced the StatChartOptionsEditorSettings to allow users to select the desired text mode. Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>
AntoineThebaud
left a comment
AntoineThebaud
left a comment
There was a problem hiding this comment.
Thanks for your PR 🙏 LGTM except the comment below; please also deal with the conflict and we shall get this merged quickly :)
Co-authored-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr> Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>
935fecf to
6d7fd23
Compare
Accepted your suggestion. Looks much simpler. Thnx! |
|
Looks like this PR has been forgotten by us, I am really sorry about that @abelyakin. @Gladorme can you please review this long waited PR ? Thank you |
|
Hi @abelyakin I have tried to finish your PR to be able to merge the feature you proposed. Unfortunately I cannot resolve these new conflicts as I believe there is different logic about how to manage the legend from main and from your PR. And I am not sure how to merge them to make something coherent. I believe it will be better if you can finish your PR. If you cannot do it as you move to something else, perhaps someone with better knowledge than myself can take care about it. |
4 participants
Description
following issue #501
Implements Grafana's text mode feature to provide users with explicit control over what's displayed in stat panels. Previously, users were confused about when to use metricLabel vs legendFormat, and there was no way to show series names alongside values.
legendFormat: Template for formatting series names (e.g., {{instance}} - {{job}}). Applied to all series for display purposes.
metricLabel: Selects which label's value to display instead of the calculated number (e.g., show the "status" label value like "healthy" or "degraded" rather than a numeric metric).
textMode: Controls what to show - the calculated value, series name, both, or neither.
Updated and simplified the migration logic to map
textModefrom panel options and handle various display scenarios.Grafana's textMode values pass through directly without conversion. Existing panels default to auto for backward compatibility.
Screenshots
text mode = name
text mode = value
text mode = value and name
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes