Conversation
The map screen threw at start without MAPS_API_KEY; OSM needs no key, so it now stands in for Google in both the map and the history screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016xeHfDLMuUeusX9PEgNEmY
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A build without
MAPS_API_KEYcrashes when the map screen opens (a fork, or a local build withoutsecrets.properties). CONTRIBUTING says the app builds without a key but the map will not load; in practice the app does not start.When the build has no Maps key and Google Maps is the chosen provider,
MapProviderFactory.effectiveProviderfalls back to OpenStreetMap, which needs no key. The map screen and the history screen both use it. Builds with a key behave exactly as before, and AMap is untouched.Verified: on a phone, a debug build without a key: the app starts and shows OSM on the map and in history.
./gradlew testAllandadd_strings.py --checkpass.