Conversation
CustomAccessoryParser never set ownedBeaconAccessoryJson, so Ring on the map card had nothing to derive addresses from and always reported "Could not compute this accessory's current address". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016xeHfDLMuUeusX9PEgNEmY
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Ring on the map card for a self-generated tag (OpenHaystack / Macless Haystack keys) always fails with "Could not compute this accessory's current address". Play sound from the device screen works for the same tag.
The map card reads the accessory JSON from the beacon model, and
CustomAccessoryParsernever setownedBeaconAccessoryJson, so there was nothing to derive the tag's addresses from. The device screen reads it from the database row instead, which is why it worked there. The fix sets it in the parser.Verified: on a phone, with a self-made OpenHaystack tag: Ring on the map card now finds and rings it.
./gradlew testAllandadd_strings.py --checkpass.Not verified: exported official AirTags are not affected by this parser, and were not retested.