release: 1.23.0

[forkline-bot]

Release 1.23.0

Fixed

• Corrected requireNotNull ordering in VersioningPlugin so null checks work as intended

---

This PR was generated by Forkline — AI-powered code contributions.
The agent analyzed the issue and implemented this fix autonomously.

[forkline-bot]

Maintainability Review

Initial expected implementation: matched
Initial reason: The PR fix (requireNotNull ordering in VersioningPlugin) is correctly implemented — requireNotNull wraps getProperty() and .toInt() is called on the non-null result.
Applied maintenance work: 3 small fixes (see below)
Final implementation: matches
Validation: build-logic compiles successfully; Android SDK not writable in this environment so full app lint could not run

Applied changes

1. VersioningPlugin.kt:22 — KDoc said "BuildDir directory" but code reads from layout.projectDirectory. Fixed to match implementation.
2. ApplicationPlugin.kt:58-64 — Removed dead isSnapshot() method (never called anywhere in the codebase).
3. PSLUpdateTask.kt:78 — Fixed double-negative typo: "is not not in" → "is not in".

Findings not applied (recommend, but defer)

Priority	Category	Location	Problem
medium	bug	VersioningTask.kt:24-26	Version code formula major*10000 + minor*100 + patch silently collides when minor or patch >= 100 (e.g. 1.100.0 == 2.0.0). Consider validating bounds or widening the encoding.
medium	bug	AppSigning.kt:26-29	as String casts on Properties values throw bare NPE with no context when keys are missing. requireNotNull with descriptive messages would improve debuggability.
low	refactor	VersioningPlugin.kt:31	AtomicBoolean is unnecessary in single-threaded Gradle configuration; a simple var suffices.
low	refactor	AndroidCommon.kt:21-61	Near-identical packaging excludes duplicated between ApplicationExtension and LibraryExtension blocks.

---

This review was generated by Forkline — AI-powered code contributions.

[forkline-bot]

✅ Fix pushed:

Fixed the CI failure by applying spotless formatting to two files:

• build-logic/src/main/kotlin/app/passwordstore/gradle/ApplicationPlugin.kt - removed extra blank line
• build-logic/src/main/kotlin/app/passwordstore/gradle/versioning/VersioningPlugin.kt - fixed comment line wrapping

The spotlessKotlinCheck task now passes. Commit 145e8db has been pushed to release/1.23.0-v2.