Repository navigation
Conversation
The keybindings doc has listed left (and h) for this since the first commit, but the main pane stopped handling them in 4f2d400, so from the keyboard the resource list could only be reached with tab or shift+tab, as p10node#45 found. Left in the main pane now focuses the list again, the mirror of right there, and leaves the open view as it is. While the main pane is zoomed the list is off screen, so left stays put. h is not bound with it: docs/plan.md gives h to the history action of the Helm view. The docs drop h, and the tab row of the Global table now says command box, as the Focus section and the code do. The in-app help names left next to tab for reaching the list. Signed-off-by: Adao Oliveira Jr <junior@users.noreply.github.com>
j and k have not moved the selection since 4f2d400: k opens the command box with "k" already typed, as k is a command name, and j is not bound. The in-app help says so and docs/keybindings.md does not list them, but the README's short table still did. Signed-off-by: Adao Oliveira Jr <junior@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45.
The keybindings doc has listed left (and h) as the way from the main pane to the resource list since the first commit, but the main pane stopped handling them in 4f2d400. From the keyboard the list could only be reached with tab or shift+tab, which is what #45 ran into. Left in the main pane now focuses the list again, the mirror of right there, and the view open in the main pane stays as it is: moving focus is not picking. While the main pane is zoomed the list is off screen, so left stays put.
h is not bound with it: docs/plan.md gives h to the history action of the Helm view, so the docs drop it. While there, the tab row of the Global table said Resources -> Main -> Actions; it now says command box, as the Focus section and the code do. The README's short table gains a left / right row, the Focus sections of keybindings.md and ui.md say how it works, and the in-app help names left next to tab for reaching the list.
The second commit drops
j/kfrom the README's short table. They have not moved the selection since 4f2d400 either: k opens the command box with "k" already typed, and j is not bound. The in-app help already says so.Tests:
TestLeftFocusesTheResourceListAndRightComesBack,TestLeftKeepsTheOpenViewandTestLeftWhileZoomedStaysInTheMainPaneininternal/ui. The first two fail without the change. gofmt, vet andgo test -short ./...pass on Go 1.26.11 and 1.27.4, and so do-raceon.,internal/k8sandinternal/uiand govulncheck on 1.27.4.