Skip to content

fix(ui): let left move focus from the main pane to the resource list - #46

Open
junior wants to merge 2 commits into
p10node:mainfrom
junior:left-focuses-resources
Open

junior wants to merge 2 commits into
p10node:mainfrom
junior:left-focuses-resources

Conversation

@junior

@junior junior commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Closes #45.

The keybindings doc has listed left (and h) as the way from the main pane to the resource list since the first commit, but the main pane stopped handling them in 4f2d400. From the keyboard the list could only be reached with tab or shift+tab, which is what #45 ran into. Left in the main pane now focuses the list again, the mirror of right there, and the view open in the main pane stays as it is: moving focus is not picking. While the main pane is zoomed the list is off screen, so left stays put.

h is not bound with it: docs/plan.md gives h to the history action of the Helm view, so the docs drop it. While there, the tab row of the Global table said Resources -> Main -> Actions; it now says command box, as the Focus section and the code do. The README's short table gains a left / right row, the Focus sections of keybindings.md and ui.md say how it works, and the in-app help names left next to tab for reaching the list.

The second commit drops j/k from the README's short table. They have not moved the selection since 4f2d400 either: k opens the command box with "k" already typed, and j is not bound. The in-app help already says so.

Tests: TestLeftFocusesTheResourceListAndRightComesBack, TestLeftKeepsTheOpenView and TestLeftWhileZoomedStaysInTheMainPane in internal/ui. The first two fail without the change. gofmt, vet and go test -short ./... pass on Go 1.26.11 and 1.27.4, and so do -race on ., internal/k8s and internal/ui and govulncheck on 1.27.4.

The keybindings doc has listed left (and h) for this since the first
commit, but the main pane stopped handling them in 4f2d400, so from the
keyboard the resource list could only be reached with tab or shift+tab,
as p10node#45 found. Left in the main pane now focuses the list again, the
mirror of right there, and leaves the open view as it is. While the
main pane is zoomed the list is off screen, so left stays put.

h is not bound with it: docs/plan.md gives h to the history action of
the Helm view. The docs drop h, and the tab row of the Global table now
says command box, as the Focus section and the code do. The in-app
help names left next to tab for reaching the list.

Signed-off-by: Adao Oliveira Jr <junior@users.noreply.github.com>
j and k have not moved the selection since 4f2d400: k opens the
command box with "k" already typed, as k is a command name, and j is
not bound. The in-app help says so and docs/keybindings.md does not
list them, but the README's short table still did.

Signed-off-by: Adao Oliveira Jr <junior@users.noreply.github.com>
@junior
junior requested a review from pierreneter as a code owner November 18, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard navigation between the Resources sidebar and the resource table

1 participant