Repository navigation
Fix the flaky spawn std test - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
treats std as live while stdBuffer preserves historytest starts a child that writes "early" and then writes "late" from a 25ms timer, and expects astdlistener attached once "early" has arrived to receive only "late". When the test process reads the pipe late, for example on a busy runner, both writes arrive as a single chunk, so the listener receives nothing and the test fails. This makes the child write "late" when its stdin closes, as theshouldCloseStdintest already does, and closes stdin once the listener is attached, so the second write can no longer arrive with the first. The same fix for osls is in oss-serverless/osls#507 and oss-serverless/osls#508.