Repository navigation
Upgrade ESLint and its plugins - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint-plugin-import-x 4.18.0, published on 6 November, imports
@typescript-eslint/utilsat runtime but only declares it as an optional peer dependency, so a fresh install like the one CI does cannot load the ESLint config, and the lint job will fail on the next pull request that changes a JavaScript file. The fix is merged upstream in un-ts/eslint-plugin-import-x#599 but has not been released, so this pins eslint-plugin-import-x to 4.17.1, the last release without the problem, and raises eslint, eslint-plugin-n and globals to the latest releases in their current major versions.@eslint/jsand eslint-config-prettier are already on theirs. None of these releases add rules to the recommended configs we extend, so the config is unchanged and the codebase still lints cleanly.