Skip to content

fix(core): omit DPoP proofs from failure logs - #4027

Draft
strantalis wants to merge 2 commits into
mainfrom
codex/auth-safe-debug-logging
Draft

strantalis wants to merge 2 commits into
mainfrom
codex/auth-safe-debug-logging

Conversation

@strantalis

@strantalis strantalis commented Sep 10, 2026

Copy link
Copy Markdown
Member

Proposed Changes

Authentication failures in the raw HTTP handler wrote the complete DPoP proof header to warning logs. This removes the proof while preserving the warning level and validation reason. The warning retains bounded diagnostic context: request method, DPoP proof count, nonce requirement, and strict-HTU mode.

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

  • make fmt
  • go test -race ./internal/auth/... from service/
  • go test -run TestREADMECodeBlocks from sdk/
  • make lint stops at buf lint because the configured Buf API token is invalid.
  • make test passes the changed auth package under the race detector, then fails in existing integration suites because Colima/Docker containers and the local round-trip server are unavailable.

Signed-off-by: strantalis <strantalis@virtru.com>
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: strantalis <strantalis@virtru.com>
@github-actions

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 209.707498ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 121.146893ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 446.968218ms
Throughput 223.73 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 55.726819487s
Average Latency 555.795439ms
Throughput 89.72 requests/second

@strantalis strantalis changed the title fix(auth): omit DPoP proofs from failure logs fix(core): omit DPoP proofs from failure logs Sep 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 121.862313ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 60.750368ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 233.899607ms
Throughput 427.53 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 31.940328689s
Average Latency 318.717669ms
Throughput 156.54 requests/second

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

  • otdfctl
  • service
  • tests-bdd

See the workflow run for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant