Skip to content

Consume the promoted S2I content set in tempest-multinode - #2068

Open
rebtoor wants to merge 1 commit into
mainfrom
feature/anvil-275-s2i-gate
Open

Consume the promoted S2I content set in tempest-multinode#2068
rebtoor wants to merge 1 commit into
mainfrom
feature/anvil-275-s2i-gate

Conversation

@rebtoor

@rebtoor rebtoor commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Enable cifmw_s2i_content_set on openstack-operator-tempest-multinode so the job deploys digest-pinned service images from quay.io/openstack-s2i-containers together with the current operator bundle.
  • Keep the job non-voting until soak.
  • Check out s2i-openstack-containers so the resolver can read image mappings; do not add an s2i content-provider parent.
  • Inject the full mapped set. s2i-openstack-deploy-validation on s2i main no longer skips neutron/mariadb (c0bc00e, 5c614ee).

Related-Issue: ANVIL-275

Depends-On: openstack-k8s-operators/ci-framework#4167
Depends-On: openstack-k8s-operators/s2i-openstack-containers#187
Depends-On: https://review.rdoproject.org/r/c/config/+/59025

Test plan

  • Zuul check: openstack-operator-tempest-multinode is scheduled and remains non-voting
  • Job log shows the resolved content set (s2iCommit + digests) applied via set_containers
  • Unmapped keys stay on payload defaults

@openshift-ci
openshift-ci Bot requested review from dprince and fultonj September 8, 2026 12:43
@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 338314 bytes (330KB)
Base branch size 338314 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 67918940-4065-46a4-b3ae-c310ae90cc18

📥 Commits

Reviewing files that changed from the base of the PR and between 1ff06f2 and 0d331c9.

📒 Files selected for processing (1)
  • zuul.d/jobs.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Updated the multinode testing configuration to include the required container project and content set.
    • Marked the multinode test job as non-voting.
    • Configured the job to use the specified container content during test execution.
    • Retained the existing configuration for selected networking and database images to be skipped during the test run.

Walkthrough

The Tempest multinode job is now non-voting. It requires the S2I containers project and enables the S2I content set.

Changes

Tempest job configuration

Layer / File(s) Summary
Update Tempest job definition
zuul.d/jobs.yaml
The job is marked non-voting, adds openstack-k8s-operators/s2i-openstack-containers as a required project, and enables cifmw_s2i_content_set.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 0d331

The Tempest multinode check now consumes the promoted S2I image content set while remaining non-voting during soak. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: consuming the promoted S2I content set in the tempest multinode job.
Description check ✅ Passed The description directly explains the S2I content-set changes, non-voting status, dependencies, and test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/anvil-275-s2i-gate

Comment @coderabbitai help to get the list of available commands.

@centosinfra-prod-github-app

Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#4167 is needed.

@rebtoor

rebtoor commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@centosinfra-prod-github-app

Copy link
Copy Markdown

Comment thread zuul.d/jobs.yaml Outdated
Wire openstack-operator-tempest-multinode to cifmw_s2i_content_set so
the job deploys digest-pinned service images from
quay.io/openstack-s2i-containers. Keep the job non-voting until soak.

Related-Issue: ANVIL-275
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebtoor
rebtoor force-pushed the feature/anvil-275-s2i-gate branch from 1ff06f2 to 0d331c9 Compare September 9, 2026 11:37
@centosinfra-prod-github-app

Copy link
Copy Markdown

@rebtoor
rebtoor requested a review from karelyatin September 10, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants