Disable ManilaShare v1 by default in 19

[fmount]

19 Manila services do not provide ManilaShareV1 endpoints anymore. This change switches this behavior by providing the annotation that instruct manila-operator to not create v1 endpoints anymore.

Jira: https://redhat.atlassian.net/browse/OSPRH-36292

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fmount
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

OpenStackControlPlane CRD Size Report

Metric	Value
CRD JSON size	338280 bytes (330KB)
Base branch size	338280 bytes
Change	+0.00%
Status	yellow — growing

Threshold reference

Color	Range	Meaning
🟢 green	< 300KB	Comfortable
🟡 yellow	300–400KB	Growing
🟠 orange	400–750KB	Concerning
🔴 red	> 750KB	Approaching 1.5MB etcd limit (cut in half to allow space for update)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Team

Run ID: 217ba5f7-c3e0-4bd8-a369-3b27999c9762

📥 Commits

Reviewing files that changed from the base of the PR and between e22415e and 7ecf1fb.

📒 Files selected for processing (1)

• internal/openstack/version.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Summary

Summary by CodeRabbit

• Changes
  • Manila Share v1 is now disabled by default when initializing OpenStack version services.

Walkthrough

The OpenStack version service now disables Manila sharev1 by default during initialization.

Changes

Manila version default

Layer / File(s)	Summary
Update Manila sharev1 default internal/openstack/version.go	InitializeOpenStackVersionServiceDefaults now sets ManilaSharev1 to disabled.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7ecf1

The change disables ManilaShareV1 endpoint creation by default for the 19 release; no actionable merge-blocking risk remains, and it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: disabling ManilaShare v1 by default in version 19.
Description check	✅ Passed	The description explains that ManilaShareV1 endpoints are no longer provided in version 19 and links the change to the relevant Jira issue.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[fmount]

main is 19, and this boolean can now be switched. However I'd like to confirm first if CI gets impacted by this considering that we still have Antelope images running.
Before removing dnm label I'll make some tests and confirm that.

[fmount]

/test openstack-operator-build-deploy-kuttl-4-20

[fmount]

Let's wait for this one until we have s2i jobs in manila-operator.