Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rheslop: This pull request references CNV-85776 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
size/L
0xFelix
left a comment
0xFelix
left a comment
There was a problem hiding this comment.
There is also virtctl template convert, which tries to convert an existing OpenShift Template to a native VirtualMachineTemplate. It could be worth mentioning that.
|
|
||
| .Procedure | ||
|
|
||
| . Create a `VirtualMachineTemplateRequest` manifest: |
There was a problem hiding this comment.
There's also a virtctl command for this. (virtctl template create)
There was a problem hiding this comment.
Would it be better to revise so that virtctl commands are used in place pf the current procedure?
There was a problem hiding this comment.
I'd show both. Under the hood, virtctl does the same. But it might be more convenient to use virtctl.
|
|
||
| * You have installed the `virtctl` CLI. | ||
| * A `VirtualMachineTemplate` exists in the cluster. | ||
| * You have the `process/create` subresource permission on the `VirtualMachineTemplate` resource. |
There was a problem hiding this comment.
There's also a --local flag that can be used with virtctl template process to process a template locally. (not requiring permission on the process subresource).
There was a problem hiding this comment.
I added a note with this below if you want to take a look. Thanks!
There was a problem hiding this comment.
I've added a note that the virtctl command can also be used. Do you think we'll need more?
|
|
||
| .Procedure | ||
|
|
||
| . Create a `VirtualMachineTemplateRequest` manifest that specifies the target namespace: |
There was a problem hiding this comment.
As mentioned above, there's also a virtctl command for this.
|
🤖 Tue Sep 15 22:55:17 - Prow CI generated the docs preview: |
e477a22 to
9b6f3e0
Compare
Add Tech Preview documentation for the native VirtualMachineTemplate feature, covering enabling the feature gate, creating templates from existing VMs, cross-namespace template creation, creating VMs from templates, and a parameter reference. * Minor edits * Updates based on feedback, and auto-peer check` * Update modules/virt-convert-vm-to-reusable-template.adoc * Add more text with virtclt command, combined two modules * Adding virtclt commands
9b6f3e0 to
c3b5ec2
Compare
|
@rheslop: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Add Tech Preview documentation for the native VirtualMachineTemplate feature, covering enabling the feature gate, creating templates from existing VMs, cross-namespace template creation, creating VMs from templates, and a parameter reference.
CNV#85776
Version(s):
5.0
Issue:
https://redhat.atlassian.net/browse/CNV-85776
Link to docs preview:
QE review:
Additional information: