Fix novel on cells without counts in the hvg peaks - #76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In run_2026-09-28
novel_predictfailed on the multiome swap datasets with a missingtensor.pt. Onbmmc_multiome/swap, 3092 cells have no counts in the 1000 hvg peaks the LSI uses, so the TF-IDF divided by zero and the LSI was NaN for those cells. The validation RMSE was then never better than the initial 100000, sotrain_and_valid()never saved a model, whilenovel_trainitself still exited 0.Describe your changes
novel: treat an empty row as having a row sum of 1 in the TF-IDF, and a zero standard deviation as 1 when scaling the LSI.On the de.NBI copy of
bmmc_multiome/swap, the LSI goes from 791552 NaN values to none.Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!