Add paramsets and include/exclude filters to run_benchmark - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Ports the recent
run_benchmarkimprovements from task_template.task_info.yaml, instead of publishing_viash.yamlverbatim (Write the commit and timestamp into task_info.yaml task_template#18). Thecommitfield was never filled in correctly before.commonsubmodule to get the paramset helpers (Add paramset helpers to helper.nf common_resources#41).--method_idswith--methods_include/--methods_exclude, and add--metrics_include/--metrics_exclude(Replace method_ids with methods/metrics include and exclude task_template#20).info.variantsor a new--paramsetsfile. Scores are tagged withparamset_name/paramset, and--methods_include/--methods_excludeaccept<method_id>.<paramset_name>(Add support for paramsets task_template#23).cellmapper_linear: usemask_var: "none"instead ofnullfor the unmasked variants. Viash drops null values from the config, so these variants silently fell back tomask_var: "hvg"and duplicated their-hvgcounterparts.Heads-up:
cellmapper_linear(6 variants) andcellmapper_scvi(5 variants) now run once per variant by default, so the full benchmark gets more expensive for those two.Tested locally on
bmmc_cite/normalwith--methods_include 'mean_per_gene;cellmapper_linear.cellmapper-pca;cellmapper_linear.cellmapper-cca' --metrics_include correlation: all 13 processes succeeded and the scores are tagged with the right paramsets.Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!