Add functional_expansion method to expansion filters - #4132
Open
EdenRochmanSharabi wants to merge 1 commit into
Open
EdenRochmanSharabi wants to merge 1 commit into
EdenRochmanSharabi wants to merge 1 commit into
Conversation
Add a method to each ExpansionFilter subclass that constructs a callable function from FET (functional expansion tally) coefficients. This lets users evaluate the expanded function at arbitrary coordinates without reimplementing the basis functions themselves. Supported filters: - LegendreFilter: returns numpy.polynomial.Legendre on [-1, 1] - SpatialLegendreFilter: returns numpy.polynomial.Legendre on [min, max] - ZernikeFilter: returns openmc.Zernike(coefs, radius) - ZernikeRadialFilter: returns openmc.ZernikeRadial(coefs, radius) - SphericalHarmonicsFilter: raises NotImplementedError (future work) Resolves openmc-dev#3419
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
functional_expansion(coefficients)method to eachExpansionFiltersubclass that constructs a callable function from FET coefficients, so users
can evaluate the expanded flux (or other quantity) at arbitrary coordinates
without reimplementing basis functions.
LegendreFilter->numpy.polynomial.Legendreon [-1, 1]SpatialLegendreFilter->numpy.polynomial.Legendreon [min, max]ZernikeFilter->openmc.ZernikeZernikeRadialFilter->openmc.ZernikeRadialSphericalHarmonicsFilter->NotImplementedError(needs a new evaluator class, left for future work)All implementations reuse existing building blocks (
legendre_from_expcoef,Zernike,ZernikeRadial), so no new dependencies.Resolves #3419
Changes
openmc/filter_expansion.py: base method onExpansionFilter+ concrete implementationstests/unit_tests/test_filters.py: unit tests and roundtrip reconstruction tests (project known functions onto bases, reconstruct, verify pointwise)Checklist