Repository navigation
Conversation
Replace the hand-written key boxes with SingleKeyContainer and KeyCombinationContainer, as used by Studio and Tobira. Arrow keys and Shift are shown as icons. Remove the now unused singleKey theme tokens. This commit was largely AI generated.
The hotkeys moved from a main view into a modal opened from the header button, so they can be looked up without leaving the current view. Key recording now only runs while the edit dialog is open. Before, it kept grabbing all key presses after the dialog was discarded. While the modal is open, the editor's own hotkeys are disabled through a react-hotkeys-hook scope, so they no longer trigger behind the modal. This commit was largely AI generated.
This commit was largely AI generated.
This commit was largely AI generated.
This commit was largely AI generated.
|
This pull request is deployed at test.editor.opencast.org/1749/2026-11-13_14-47-46/ . |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking on the "Hotkeys" button in the header gave you quite the different experience from Opencast Studio or Tobira. This aims to create a more similar look and feel.
How to test this
Mostly a look and feel PR, but it would not hurt to make sure that everything pertaining to hotkeys is still working as before.
AI Usage
Used Claude Sonnet 5 for the bulk of the work.