Repository navigation
fix(OpenAI): keep logprobs on streamed chat choices - #849
Merged
iBotPeaches merged 1 commit intoNov 14, 2026
Merged
Conversation
Streamed chat chunks requested with logprobs=true carry choices[].logprobs, but CreateStreamedResponseChoice dropped them. Parse it with CreateResponseChoiceLogprobs, as the non-streamed choice does.
iBotPeaches
approved these changes
Nov 14, 2026
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
Chat completion chunks requested with
logprobs => truecarrychoices[].logprobs, butCreateStreamedResponseChoice::from()read onlyindex,deltaandfinish_reason, so the token log probabilities were dropped from every streamed chunk. The non-streamedCreateResponseChoicealready exposes them.CreateStreamedResponseChoicenow has a nullablelogprobs, parsed with the existingCreateResponseChoiceLogprobs. Chunks without logprobs keeplogprobsnull andtoArray()omits the key, so existing payloads round-trip unchanged.Tests cover a chunk with logprobs, a chunk without, and
toArray()with logprobs. The first and last fail on main. The Chat tests pass (98 passed, deprecation notices already on main). Pint and PHPStan are clean.This change was prepared with an AI coding assistant.