Repository navigation
fix(OpenAI): parse custom tool calls of chat completions - #847
Open
skybleak333 wants to merge 1 commit into
Open
skybleak333 wants to merge 1 commit into
skybleak333 wants to merge 1 commit into
Conversation
skybleak333
added a commit
to skybleak333/skybleak333
that referenced
this pull request
Nov 13, 2026
Collaborator
|
conflicts as well here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
With a custom tool (
{"type": "custom", "custom": {"name": "code_exec"}}, the free-form tools of GPT-5), a chat completion can return a tool call withoutfunction:{"id": "call_Hrb6BWd1ZW8VnnyJFdtR6dsv", "type": "custom", "custom": {"name": "code_exec", "input": "print(\"hello world\")"}}This is
ChatCompletionMessageCustomToolCallin the API reference and in openai-python.CreateResponseToolCall::from()always read$attributes['function'], sochat()->create()failed with aTypeErroron such a response, after OpenAI had run and billed it.CreateResponseToolCallnow has a nullablefunctionand acustomproperty (CreateResponseToolCallCustomwithnameandinput), andtoArray()returns whichever the API sent. Function tool calls don't change. The new tests fail without the fix, and the full suite, Pint and PHPStan pass.Not changed: streamed chunks. I couldn't check what the API streams for a custom tool call, so
CreateStreamedResponseToolCallstill expectsfunction.