Skip to content

Run the long checker binaries in their own CI jobs - #176

Open
dcharlot65-openie wants to merge 1 commit into
mainfrom
cursor/ci-split-slow-bins-c840
Open

dcharlot65-openie wants to merge 1 commit into
mainfrom
cursor/ci-split-slow-bins-c840

Conversation

@dcharlot65-openie

Copy link
Copy Markdown
Contributor

See #175.

Summary

tests-fast and checker (tree-sitter) spend most of their time in three release binaries that cargo test runs one after another. On main 9ef5c387 (run 42818858124) cargo reported form_bridge 519.3 s, break_fg8_witness 424.8 s and emit_run 305.2 s, about 20.8 minutes of a 32.03 minute Fast tests step. The same three binaries are why the tree-sitter feature suite reached 35.82 minutes on run 42818858285, and why pull request 160 reached 53.65 minutes (push) and 54.55 minutes (pull_request) on commit 069cf029.

Release compile stayed about 3 to 5 minutes, and the two feature jobs on 069cf029 hit the same rust-cache key. The cache is not what makes the step long.

This change puts those three binaries on the existing slow-job matrix. ci.yml runs each one without the tree-sitter feature. tree-sitter sync runs each one with that feature, in its own job. scripts/ci-tests.sh fast still runs every other binary, including the library tests and grammar_fuzz. Nothing is filtered, ignored, or removed. No timeout is raised. The 60 minute limits stay as they are.

Tests

bash -n on both scripts, scripts/ci-tests.sh slow-list, scripts/check-flags.py and scripts/check-removed-paths.py passed. The tests-slow matrix matches the slow list. The checker suite itself is unchanged and runs in CI.

Open in Web Open in Cursor 

cargo test runs one binary at a time. On main 9ef5c38, form_bridge, break_fg8_witness and emit_run took about 21 minutes inside tests-fast, which is why that step and the tree-sitter feature suite approached the job limit. Each binary still runs with and without the tree-sitter feature. No test is dropped.

Co-authored-by: David Charlot <dcharlot65-openie@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants