Repository navigation
Keep a count-bounded Iterate's carried order - #171
Open
dcharlot65-openie wants to merge 3 commits into
Open
dcharlot65-openie wants to merge 3 commits into
dcharlot65-openie wants to merge 3 commits into
Conversation
C7 removed an order that the test and the body only passed through, so a count that may halt lost the chain that halt sits on. The rule now keeps that order. A pure count is applied, and 42_f32.rce no longer refuses for that reason. Co-authored-by: David Charlot <dcharlot65-openie@users.noreply.github.com>
Both regions of a count are given order together, so the later check that they do not both carry it never ran. A count with no order still refuses, and the tests name that sentence. The notes that still required the old pure-count refusal now follow the erratum. A pass-through bool is still removed. Co-authored-by: David Charlot <dcharlot65-openie@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Erratum of 2026-11-13, adopted by David. C7 used to remove every carried value that neither region uses and both return unchanged, and that removal included the order of a count-bounded Iterate. A count may halt, so that order is the chain the bound halt sits on, even when the test and the body only pass it through. The rule now keeps that carried order. A measure's unused order, and every unused carried value that is not that order, are still removed. FG7, FG8 and the other gates are unchanged.
The four
boundsentencesAll four said:
bound: a count-bounded Iterate must carry ω, and C7 removes a carried ω that neither region uses, so this pure count loop has no applied form. A scan of the 60 examples on the previous checker (examples_are_covered_or_require_change, output captured) hit only the second.build_count, when the loop would not thread order. Before: 0 example hits. After: if an order is in scope the count carries it and this sentence is gone. If no order is in scope the refusal isomega: a count-bounded Iterate may halt, and this region has no ω to carry.build_count, after both regions were given order and neither used it. Before: one hit,rt.big.decin42_f32.rce(sc_omega=true,parent_omega=true, both regionsIn(0)), and the pure-count unit test (at=pure, the same shape). After: that sentence is gone. The pure count constructs, the count's first carried type isorder,construct(schedule(F))returns the same bytes, and evaluation agrees with the core for bound 1 (returns 0) and bound 0 (haltloop bound).42_f32.rceno longer carries theboundtag.loop_stmt, when the count's regions do not use order. Before: 0 example hits, because the lowering path refused first and no schedule of a pure count was constructed. After: a count whose regions were given order and only pass it through is not refused. The pure count's schedule round-trips, which is this path. If a region was not given order, the refusal isomega: a count-bounded Iterate may halt, and this region has no ω to carry.loop_stmt, when the count would not carry order (use_wfalse). Before: 0 example hits. After: the C7 sentence is gone. A count that still does not carry order is refused withomega: a count-bounded Iterate may halt, and this loop's regions do not both carry ω.The other
boundsentence,this loop's regions do not both receive it, is unchanged.Baselines
Census regenerated by
RCE_CENSUS_WRITEfrom the measured walk, not by editing numbers:42_f32.rcewhole set:bound,breaktobreak. Roots stayclear.bound,break: 1 to 0.break: 14 to 15.catch,globalenters the top 10 only becausebound,breakleft that list. It was already an exact set.Witness baseline
corpus_baseline_on_50294e05was re-run and did not move.Checks
Local runs of the
ci.ymljobs passed before push: removed paths, flags,rce-spec-check, book check, claim counts, conformance README,make.py check, T7 (51 equivalent, 0 different), clippy, fast tests, all 12 slow binaries, the wasm checker, and the tree-sitter three-parser check.