[chore] [receiver/datadogreceiver] Migrate ReverseProxy.Director to Rewrite - #50450
Open
singhvibhanshu wants to merge 2 commits into
Open
[chore] [receiver/datadogreceiver] Migrate ReverseProxy.Director to Rewrite#50450singhvibhanshu wants to merge 2 commits into
singhvibhanshu wants to merge 2 commits into
Conversation
Signed-off-by: singhvibhanshu <find.vibhanshu@gmail.com>
Pull request dashboard statusWaiting on the author · refreshed 2026-08-22 17:21 UTC Two things need attention:
Status above doesn't look right?
|
Member
|
PTAL into CI errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the intake reverse proxy from
httputil.ReverseProxy.DirectortoRewrite.Directoris deprecated as of Go 1.26 in favor ofRewrite, which has been available since Go 1.20. The rewrite hook operates onProxyRequest.Outrather than the request directly.Unlike
Director,Rewritestrips theX-Forwarded-*headers before it is called and does not re-add them. This PR callspr.SetXForwarded()to preserve the previousX-Forwarded-Forbehavior, keeping the outbound request identical.Link to tracking issue
Fixes #50418
Testing
Tuned.
Documentation
~
Authorship