Skip to content

[receiver/rabbitmq] add rabbitmq.cluster.name resource attribute - #50273

Open
ayush-singh-0601 wants to merge 5 commits into
open-telemetry:mainfrom
ayush-singh-0601:feat/rabbitmq-cluster-name
Open

[receiver/rabbitmq] add rabbitmq.cluster.name resource attribute#50273
ayush-singh-0601 wants to merge 5 commits into
open-telemetry:mainfrom
ayush-singh-0601:feat/rabbitmq-cluster-name

Conversation

@ayush-singh-0601

@ayush-singh-0601 ayush-singh-0601 commented Aug 16, 2026

Copy link
Copy Markdown

Description

add the disabled-by-default rabbitmq.cluster.name resource attribute

fetch the cluster name from RabbitMQ's /api/cluster-name endpoint once per scrape

propagate it to queue, node, and exchange metrics, with partial-error handling when lookup fails

regenerate metadata artifacts and add client/scraper coverage

Link to tracking issue

Fixes #50168

Testing

  • CGO_ENABLED=0 go test ./... (pass)
  • CGO_ENABLED=0 go vet ./... (pass)
  • git diff --check (pass)
  • go test -race ./... could not run on the local Windows image because its installed 32-bit C compiler cannot build 64-bit race binaries; upstream CI should run the race job on supported runners.

Documentation

regenerate metadata artifacts

Authorship

  • I, a human, wrote this pull request description myself.

@ayush-singh-0601
ayush-singh-0601 requested a review from a team as a code owner August 16, 2026 11:25
@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 16, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: ayush-singh-0601 / name: ayush-singh-0601 (2377f39)

@github-actions github-actions Bot added the first-time contributor PRs made by new contributors label Aug 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

  • Read our Contributing Guidelines.
  • Sign the CLA if you haven't already.
  • Follow the OpenTelemetry Generative AI policy: disclose any AI use in your contribution, and communicate (PR descriptions, review replies) in your own words rather than AI-generated text.
  • Give reviewers at least a few days before pinging them for feedback.
  • If you need help with general setup, development process, or contributor etiquette, ask in #opentelemetry-new-contributors.
  • First-time contributors should keep at most one PR marked as ready for review until their first PR is merged; once two are open for review, any further PR is automatically converted to draft.
  • If your change isn't one of our priority components, reviews may take more time.
  • Raise technical or Collector-specific questions in #otel-collector-dev or a Collector SIG meeting.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 16, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on reviewers · refreshed 2026-08-22 16:51 UTC

Review the latest changes.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@paulojmdias

Copy link
Copy Markdown
Member

@ayush-singh-0601, please sign the CLA, please check the contributing guidelines, specifically the AI assisted section, and update your PR description.

@paulojmdias

Copy link
Copy Markdown
Member

@ayush-singh-0601 please add a changelog entry

@paulojmdias

Copy link
Copy Markdown
Member

/workflow-approve

@ayush-singh-0601 ayush-singh-0601 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have fixed the issue

@ayush-singh-0601

Copy link
Copy Markdown
Author

can you suggest what should i do next

@paulojmdias

Copy link
Copy Markdown
Member

/workflow-approve

@ayush-singh-0601

Copy link
Copy Markdown
Author

it is asking for approval for the workflow can you please provide it

@singhvibhanshu

Copy link
Copy Markdown
Member

/workflow-approve

@singhvibhanshu

Copy link
Copy Markdown
Member

@ayush-singh-0601,
May I ask why have you replaced our description template with something random? I'd suggest you to check the contributing guidelines, specifically the AI assisted section, and update your PR description accordingly.

@ayush-singh-0601 ayush-singh-0601 changed the title feat(receiver/rabbitmq): add cluster name resource attribute [receiver/rabbitmq] add rabbitmq.cluster.name resource attribute Aug 22, 2026
@ayush-singh-0601

Copy link
Copy Markdown
Author

i updated my pr description, sorry for the change in description , wont happen again
if there is any changes i need to make please do tell

@singhvibhanshu

singhvibhanshu commented Aug 22, 2026

Copy link
Copy Markdown
Member

Also check the (I, a human, wrote ...) checkbox. Also, make sure that this won't happen again, otherwise it may lead to closing to your upcoming PRs. For more info, read our contributing guidelines.

@singhvibhanshu

Copy link
Copy Markdown
Member

/workflow-approve

@ayush-singh-0601

Copy link
Copy Markdown
Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[receiver/rabbitmq] Add rabbitmq.cluster.name resource attribute ( RabbitMQ cluster Name )

3 participants