Add support for partitioning by probe_id in the window functions - #187
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 83.65% 83.84% +0.18%
==========================================
Files 89 89
Lines 5917 5985 +68
==========================================
+ Hits 4950 5018 +68
Misses 967 967
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LDiazN
reviewed
Sep 24, 2026
Contributor
|
Looks good in general, just a small comment. Do you think it's feasible to make a test to run this against actual data? The current test just checks the query string consistency |
Demonstrate how without the change a measurement would erroneously be marked as "IPv6 broken", while it was actually IPv6 blocking
* Fix the tests so that they don't include TLS measurements which never happen if TCP is failing
Member
Author
|
I implemented some new tests and made some changes to the rules in order to distinguish IPv4 from IPv6 failures |
LDiazN
reviewed
Sep 25, 2026
LDiazN
reviewed
Sep 25, 2026
When that's happening we aren't triggering TCP blocking
Member
Author
|
I pushed changes that:
|
LDiazN
reviewed
Sep 25, 2026
| ok=0.0, | ||
| layer=RuleLayer.TCP, | ||
| outcome_class=OutcomeClass.DOWN, | ||
| comment="Failure against an address that is nor v4 nor v4 that mostly succeeds in the control. This should in theory never trigger", |
Contributor
There was a problem hiding this comment.
Suggested change
| comment="Failure against an address that is nor v4 nor v4 that mostly succeeds in the control. This should in theory never trigger", | |
| comment="Failure against an address that is nor v4 nor v6 that mostly succeeds in the control. This should in theory never trigger", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #162