fix(ci): keep SBOM output out of dist/ so PyPI publish doesn't choke on it - #371
Merged
Merged
Conversation
…on it pypa/gh-action-pypi-publish globs dist/* by default and tries to upload every file there to PyPI as a distribution artifact. The "Generate SBOM" step (added in #368) wrote bom.json/bom.xml straight into dist/ alongside the real wheel/sdist, so the publish step's pre-upload check failed on bom.json ("InvalidDistribution: Unknown distribution format") and aborted before uploading anything -- confirmed live on the v6.1.16 tag push, the first release run since that step was added. Write the SBOM to its own sbom/ directory instead, and attach both dist/* and sbom/* to the GitHub Release. Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bom.json/bom.xmlintodist/alongside the real wheel/sdist.pypa/gh-action-pypi-publishglobsdist/*by default and tried to upload the SBOM files as distribution artifacts, failing the pre-upload check ("InvalidDistribution: Unknown distribution format: 'bom.json'") and aborting before anything was uploaded.sbom/directory, and attach bothdist/*andsbom/*to the GitHub Release.Test plan
🤖 Generated with Claude Code