Respect --kernel and --language in --help-notebook - #907
Open
fzlzjerry wants to merge 1 commit into
Open
Conversation
fzlzjerry
marked this pull request as ready for review
August 10, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
--help-notebookreturned through the inspection path without forwarding theCLI's
--kernelor--languagevalues, so translator selection relied only onnotebook metadata. This change threads both overrides through that path.
Parameter inference now uses an exact registered kernel translator without
requiring separate language metadata. For unregistered or custom kernels, it
continues to fall back to the supplied or notebook language. CLI regression
coverage exercises both kernel cases and the explicit language override.
Validation:
pytest papermill/tests -q(550 passed)pre-commit run --files papermill/cli.py papermill/inspection.py papermill/tests/test_cli.pycheck-manifestFixes #905