Skip to content

Respect --kernel and --language in --help-notebook - #907

Open
fzlzjerry wants to merge 1 commit into
nteract:mainfrom
fzlzjerry:fix/905-help-notebook-overrides
Open

Respect --kernel and --language in --help-notebook#907
fzlzjerry wants to merge 1 commit into
nteract:mainfrom
fzlzjerry:fix/905-help-notebook-overrides

Conversation

@fzlzjerry

Copy link
Copy Markdown

What does this PR do?

--help-notebook returned through the inspection path without forwarding the
CLI's --kernel or --language values, so translator selection relied only on
notebook metadata. This change threads both overrides through that path.

Parameter inference now uses an exact registered kernel translator without
requiring separate language metadata. For unregistered or custom kernels, it
continues to fall back to the supplied or notebook language. CLI regression
coverage exercises both kernel cases and the explicit language override.

Validation:

  • pytest papermill/tests -q (550 passed)
  • pre-commit run --files papermill/cli.py papermill/inspection.py papermill/tests/test_cli.py
  • check-manifest

Fixes #905

@fzlzjerry
fzlzjerry marked this pull request as ready for review August 10, 2026 19:58
Copilot AI lite review requested due to automatic review settings August 10, 2026 19:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--help-notebook does not respect --kernel CLI argument

2 participants