lib: put node:bench behind an --experimental-bench flag - #65920
Open
jasnell wants to merge 2 commits into
Open
Conversation
jasnell
added
benchmark
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
ljharb
approved these changes
Sep 8, 2026
jasnell
force-pushed
the
jasnell/node-bench-flag
branch
from
September 8, 2026 21:32
7575fec to
79fa17e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
RafaelGSS
approved these changes
Sep 8, 2026
I believe the test-bench-cli flakes were just because the one file was doing too much and on some architectures was taking too long to complete. This splits up the file. At the very least, if there's still a flake in here, the smaller, more focused files should help narrow it down Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
jasnell
force-pushed
the
jasnell/node-bench-flag
branch
from
September 9, 2026 01:25
79fa17e to
b3204fc
Compare
Collaborator
H4ad
approved these changes
Sep 9, 2026
meixg
approved these changes
Sep 9, 2026
meixg
added
the
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as duplicate.
This comment was marked as duplicate.
marco-ippolito
approved these changes
Sep 9, 2026
Contributor
|
@meixg why do you add
request-ci
|
Member
Sorry about that, I didn't check carefully, My bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks after #65919 .. the first commit here is from that
The second commit puts the experimental
node:benchproperly behind the--experimental-benchflag, which I completely missed on the initial landing.