test_runner: capture process state in entry point instead of runner - #65915
Closed
krsnaSuraj wants to merge 1 commit into
Closed
test_runner: capture process state in entry point instead of runner#65915krsnaSuraj wants to merge 1 commit into
krsnaSuraj wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
krsnaSuraj
pushed a commit
to krsnaSuraj/node
that referenced
this pull request
Sep 8, 2026
Move process.* reads (process.argv, process.env, process.cwd) from runner.js to the CLI entry point (main/test_runner.js), so that runner.js can be loaded without side effects in snapshot environments. The execArgv case is handled via a fallback in getRunArgs(): when no execArgv is passed in options, process.execArgv is still read directly to propagate V8-only flags to child processes. PR-URL: nodejs#65915 Refs: nodejs#56131
krsnaSuraj
force-pushed
the
fix/53867-capture-process-state-in-entry-point
branch
from
September 8, 2026 17:20
e34b465 to
e71c440
Compare
nodejs-github-bot
added
needs-ci
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
krsnaSuraj
pushed a commit
to krsnaSuraj/node
that referenced
this pull request
Sep 8, 2026
Move process.* reads (process.argv, process.env, process.cwd) from runner.js to the CLI entry point (main/test_runner.js), so that runner.js can be loaded without side effects in snapshot environments. The execArgv case is handled via a fallback in getRunArgs(): when no execArgv is passed in options, process.execArgv is still read directly to propagate V8-only flags to child processes. PR-URL: nodejs#65915 Refs: nodejs#56131 Signed-off-by: Krsna Suraj <krsnasuraj@gmail.com>
krsnaSuraj
force-pushed
the
fix/53867-capture-process-state-in-entry-point
branch
from
September 8, 2026 17:27
e71c440 to
ea13c78
Compare
Move process.* reads (process.argv, process.env, process.cwd) from runner.js to the CLI entry point (main/test_runner.js), so that runner.js can be loaded without side effects in snapshot environments. The execArgv case is handled via a fallback in getRunArgs(): when no execArgv is passed in options, process.execArgv is still read directly to propagate V8-only flags to child processes. PR-URL: nodejs#65915 Refs: nodejs#56131 Signed-off-by: Krsna Suraj <krsnasuraj@gmail.com>
krsnaSuraj
force-pushed
the
fix/53867-capture-process-state-in-entry-point
branch
from
September 8, 2026 18:24
ea13c78 to
a1be614
Compare
krsnaSuraj
deleted the
fix/53867-capture-process-state-in-entry-point
branch
September 8, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves process.* reads (process.argv, process.env, process.cwd) from runner.js to the CLI entry point (main/test_runner.js), so that runner.js can be loaded without side effects in snapshot environments.
The execArgv case is handled via a fallback in getRunArgs(): when no execArgv is passed in options, process.execArgv is still read directly to propagate V8-only flags to child processes.
Supersedes #64446 (which GitHub auto-closed after a force-push).
Refs: #56131