Skip to content

Update cppgc_helpers.cc - #65871

Open
gugu8intel-i9 wants to merge 1 commit into
nodejs:mainfrom
gugu8intel-i9:patch-1
Open

Update cppgc_helpers.cc#65871
gugu8intel-i9 wants to merge 1 commit into
nodejs:mainfrom
gugu8intel-i9:patch-1

Conversation

@gugu8intel-i9

Copy link
Copy Markdown

This PR optimizes CppgcWrapperList::PurgeEmpty() by replacing redundant iterator copies with in-place increments and removing unnecessary manual handle clearing. It also modernizes Cleanup() and MemoryInfo() using scoped variable initialization for improved readability and performance.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.18%. Comparing base (695f01f) to head (62ffbdc).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/cppgc_helpers.cc 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65871      +/-   ##
==========================================
- Coverage   90.19%   90.18%   -0.02%     
==========================================
  Files         771      771              
  Lines      264628   264624       -4     
  Branches    50237    50238       +1     
==========================================
- Hits       238683   238642      -41     
- Misses      16953    16962       +9     
- Partials     8992     9020      +28     
Files with missing lines Coverage Δ
src/cppgc_helpers.cc 75.00% <66.66%> (ø)

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399

Copy link
Copy Markdown
Contributor

See Commit message guidelines according to the Pull requests documentation.

Your previously submitted invalid PR #65360 was rejected partially for the same reason.

@MikeMcC399

Copy link
Copy Markdown
Contributor

This PR is failing linting tests. See the comments in the tests for more detail.

See also Pull requests > Step 6: Test with further details in the linked document section BUILDING > Running tests.

To run the linter, use make lint / vcbuild lint. It will lint JavaScript, C++, and Markdown files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:mixed-signals c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants