sqlite: always copy changeset before applying - #65870
Open
trivikr wants to merge 1 commit into
Open
Conversation
SQLite can invoke JavaScript through user-defined SQL functions while applying a changeset, even when no filter or conflict callback is set. Copy non-empty changesets unconditionally so JavaScript cannot detach or modify the input while SQLite is still reading it. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
trivikr
added
the
request-ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65870 +/- ##
==========================================
- Coverage 90.19% 90.18% -0.01%
==========================================
Files 771 771
Lines 264628 264627 -1
Branches 50237 50235 -2
==========================================
- Hits 238683 238658 -25
- Misses 16953 16960 +7
- Partials 8992 9009 +17
🚀 New features to boost your workflow:
|
Contributor
|
It seems the same as Matteo did in his first implementation. If we're on this endeavor, I'd rather have track of all the user defined functions and prevent them being called on all the surfaces. WDYT? |
Member
Author
Created #65880 to track registered user-defined functions separately. Can we keep this PR focused on protecting the changeset buffer while preserving existing SQL function behavior? |
geeksilva97
approved these changes
Sep 7, 2026
geeksilva97
added
request-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #65286 (comment)
SQLite can invoke JavaScript through user-defined SQL functions while applying a changeset, even when no filter or conflict callback is set. Copy non-empty changesets unconditionally so JavaScript cannot detach or modify the input while SQLite is still reading it.
Assisted-by: codex