Skip to content

zlib: improve zstd decoding across chunk boundaries - #65865

Open
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/zlib-decode-concat-skippable
Open

zlib: improve zstd decoding across chunk boundaries#65865
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/zlib-decode-concat-skippable

Conversation

@jasnell

@jasnell jasnell commented Sep 6, 2026

Copy link
Copy Markdown
Member

Discovered when testing some other changes that zstd was not handling certain chunk boundaries very well. This fixes it.

  • Decodes concatenated and skippable zstd frames across all chunk boundaries.
  • Preserves rejectGarbageAfterEnd semantics.
  • Reports corruption in subsequent frames.
  • Handles trailing partial frame identifiers consistently.
  • Covers classic sync/async and iterable APIs.
  • Updated documentation and internal typings.

Technically a behavior change but zstd is still experimental.

Discovered when testing some other changes that zstd was not
handling certain chunk boundaries very well. This fixes it.

- Decodes concatenated and skippable zstd frames across all chunk boundaries.
- Preserves rejectGarbageAfterEnd semantics.
- Reports corruption in subsequent frames.
- Handles trailing partial frame identifiers consistently.
- Covers classic sync/async and iterable APIs.
- Updated documentation and internal typings.

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. typings Issues and PRs related to internal TypeScript declarations. zlib Issues and PRs related to the zlib module and its compression dependencies. labels Sep 6, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.46341% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.19%. Comparing base (8af7545) to head (461b2a7).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/node_zlib.cc 90.41% 2 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65865   +/-   ##
=======================================
  Coverage   90.18%   90.19%           
=======================================
  Files         771      771           
  Lines      264619   264687   +68     
  Branches    50231    50256   +25     
=======================================
+ Hits       238653   238735   +82     
+ Misses      16961    16952    -9     
+ Partials     9005     9000    -5     
Files with missing lines Coverage Δ
lib/zlib.js 98.15% <100.00%> (+<0.01%) ⬆️
src/node_zlib.cc 79.91% <90.41%> (+0.72%) ⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. typings Issues and PRs related to internal TypeScript declarations. zlib Issues and PRs related to the zlib module and its compression dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants