quic: fix crash in onStreamClose - #65861
Open
martenrichter wants to merge 1 commit into
Open
Conversation
onStreamClose could crash, if this[kOwner] was not set. Signed-off-by: Marten Richter <marten.richter@freenet.de>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
Author
jasnell
approved these changes
Sep 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65861 +/- ##
==========================================
+ Coverage 90.14% 90.20% +0.06%
==========================================
Files 769 771 +2
Lines 262968 264620 +1652
Branches 50060 50226 +166
==========================================
+ Hits 237057 238710 +1653
+ Misses 16932 16905 -27
- Partials 8979 9005 +26
🚀 New features to boost your workflow:
|
bjohansebas
approved these changes
Sep 6, 2026
bjohansebas
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
meixg
approved these changes
Sep 7, 2026
jasnell
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onStreamClose could crash, if
this[kOwner]was not set.