stream: fix ERR_INVALID_STATE when cancelling Readable.toWeb()

[richardscarrott]

When a web ReadableStream returned by Readable.toWeb() is cancelled while the underlying Readable is actively producing data, a pending onData callback can still fire after the controller has been closed and attempt to enqueue a chunk, throwing ERR_INVALID_STATE.

Check wasCanceled in the onData handler and return early to avoid calling controller.enqueue() on a closed controller.

Refs: #54205

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (fd5b135) to head (c0fe52d).
⚠️ Report is 402 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62773      +/-   ##
==========================================
+ Coverage   90.12%   90.17%   +0.05%     
==========================================
  Files         752      771      +19     
  Lines      252325   264910   +12585     
  Branches    47456    50310    +2854     
==========================================
+ Hits       227407   238894   +11487     
- Misses      16217    16981     +764     
- Partials     8701     9035     +334     

Files with missing lines	Coverage Δ
lib/internal/webstreams/adapters.js	88.04% <100.00%> (+1.43%)	⬆️

... and 260 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[efekrskl]

Thank you for your contribution @richardscarrott!

Could you please fix the linting errors?

[smoores-dev]

Howdy folks! I think we're running into this as well — @richardscarrott if you don't have time to take this over the finish line, happy to take it over and fix the linting errors!

[richardscarrott]

@smoores-dev @efekrskl soz, forgot about this. I have some time tomorrow to fix this up.

[richardscarrott]

Rebased onto main and fixed the lint error.

Worth flagging for re-review: #62394 rewrote newReadableStreamFromStreamReadable after this PR was opened, so the patch needed porting — the onData logic now lives in an inline 'data' listener. I confirmed the race is still present on current main; without the guard, test-stream-readable-to-web-termination.js fails with:

TypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closed
    at ReadableStreamDefaultController.enqueue (node:internal/webstreams/readablestream:1189:13)
    at Readable.onData (node:internal/webstreams/adapters:547:18)
    at flow (node:internal/streams/readable:1319:53)
    at resume_ (node:internal/streams/readable:1295:3)

Note this is the enqueue path, distinct from the close path in #54205 (which #54206 already fixed) — hence Refs: rather than Fixes:. Upstream's rewritten test file is preserved as-is with the new case appended.

@meixg your approval predates the rebase, so this likely needs another look.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/77096/

[richardscarrott]

Added the missing Signed-off-by trailer (thanks @MikeMcC399) — message-only amend, so the tree is identical to the previously reviewed commit. lint-commit-message is green now.

Could a collaborator start a fresh CI run and re-add the author ready label? The force-push cleared it (@meixg's approval still stands).

[MikeMcC399]

Added the missing Signed-off-by trailer (thanks @MikeMcC399) — message-only amend, so the tree is identical to the previously reviewed commit. lint-commit-message is green now.

Thanks for fixing the trailer!

Could a collaborator start a fresh CI run and re-add the author ready label? The force-push cleared it (@meixg's approval still stands).

@panva is re-running the GitHub Actions CI. I have put back the author ready PRs with CI started, the required approvals, and no outstanding review comments. label, although I don't believe that's a critical point.

It's going to need another Jenkins CI triggered, however there is currently some work being done to fix a flaky test, so I'll let @panva continue looking after your PR. I'm not sure if @meixg will need to reapprove or not. We'll see!

[panva]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/77165/