Skip to content

fix: ignore fully skipped startup failures - #1170

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:ignore-skipped-startup-failures
Open

fix: ignore fully skipped startup failures#1170
panva wants to merge 1 commit into
nodejs:mainfrom
panva:ignore-skipped-startup-failures

Conversation

@panva

@panva panva commented Aug 27, 2026

Copy link
Copy Markdown
Member

GitHub Actions can report a check suite as STARTUP_FAILURE even when every check run in that suite was skipped. This caused checkGitHubCI() to mark the PR as unlandable without reporting a specific failed job or reason code.

Ignore this suite-level result when every check run was fetched and every run completed with SKIPPED. Other startup failures continue to block landing and now fall back to a suite-level diagnostic when no failed check run is available.

Query the check-run totalCount to ensure truncated results are not mistaken for a fully skipped suite.

Observed in nodejs/node#65538 (comment)

https://github.com/nodejs/node/actions/runs/32985142178/attempts/1
https://github.com/nodejs/node/actions/runs/32984879569/attempts/1

Screenshot 2026-08-27 at 23 36 02

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.86%. Comparing base (fdcfe10) to head (41303bb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
+ Coverage   57.81%   57.86%   +0.04%     
==========================================
  Files          53       53              
  Lines       10397    10409      +12     
==========================================
+ Hits         6011     6023      +12     
  Misses       4386     4386              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant